Skip to content

feat: add C implementation for math/base/special/asind #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 16, 2024
Merged

feat: add C implementation for math/base/special/asind #1876

merged 3 commits into from
Mar 16, 2024

Conversation

Rejoan-Sardar
Copy link
Contributor

Resolves # .

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/special/asind

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title feat: add C implementation for math/base/special/asind feat: add C implementation for math/base/special/asind Mar 15, 2024
Pranavchiku
Pranavchiku suggested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments above, once addressed this will be good to merge.

@Rejoan-Sardar
Update main.c
ead10ed 
Signed-off-by: Rejoan Sardar <[email protected]>
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 15, 2024
@Rejoan-Sardar
Update asind.h
3140e71 
Signed-off-by: Rejoan Sardar <[email protected]>
@Rejoan-Sardar
Copy link
Contributor Author

@Pranavchiku I have addressed all the issues you mentioned in your review. Please take a look at the changes

Planeshifter
Planeshifter approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Planeshifter Planeshifter merged commit f098571 into stdlib-js:develop Mar 16, 2024
@Rejoan-Sardar Rejoan-Sardar deleted the asind2 branch March 16, 2024 17:23
This was referenced Mar 17, 2024
Closed
Closed
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@Pranavchiku Pranavchiku Awaiting requested review from Pranavchiku

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rejoan-Sardar @Planeshifter @Pranavchiku @stdlib-bot